0--CollaborationAwareMessageBusAdapter.javaSTYLE00-modules/Actors/src/main/java/it/tidalwave/actor/impl/CollaborationAwareMessageBusAdapter.javad2d09f575203d58ca6dc11a97fe1ab2f126126it.tidalwave.actor.impl.CollaborationAwareMessageBusAdapter.registerCollaborationListener(Method) uses the same code for two branchesTheseFoolishThings :: ActorsspotbugsSpotBugsit.tidalwave.actor.impl1325LOWCollaborationAwareMessageBusAdapter.java(126,0): DB_DUPLICATE_BRANCHES: STYLE: it.tidalwave.actor.impl.CollaborationAwareMessageBusAdapter.registerCollaborationListener(Method) uses the same code for two branchesDB_DUPLICATE_BRANCHES0--ExecutorWithPriority.javaPERFORMANCE00-modules/Actors/src/main/java/it/tidalwave/actor/impl/ExecutorWithPriority.java47f5fabdcbbf82f7cbc1e7f1edd289927272The class it.tidalwave.actor.impl.ExecutorWithPriority$2 could be refactored into a named _static_ inner classTheseFoolishThings :: ActorsspotbugsSpotBugsit.tidalwave.actor.impl1325LOWExecutorWithPriority.java(72,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.actor.impl.ExecutorWithPriority$2 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--ExecutorWithPriority.javaPERFORMANCE00-modules/Actors/src/main/java/it/tidalwave/actor/impl/ExecutorWithPriority.java37846ee1c653c72d8b3a8140d78fb389103103The class it.tidalwave.actor.impl.ExecutorWithPriority$3 could be refactored into a named _static_ inner classTheseFoolishThings :: ActorsspotbugsSpotBugsit.tidalwave.actor.impl1325LOWExecutorWithPriority.java(103,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.actor.impl.ExecutorWithPriority$3 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--SimpleMessageBus.javaBAD_PRACTICE00-modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/SimpleMessageBus.javadedc8406d099b7891eac4112cb475dfa144144Adding elements of an entry set may fail due to reuse of Map.Entry object in it.tidalwave.messagebus.spi.SimpleMessageBus.dispatchMessage(Class, Object)TheseFoolishThings :: MessageBusspotbugsSpotBugsit.tidalwave.messagebus.spi1325LOWSimpleMessageBus.java(144,0): DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS: BAD_PRACTICE: Adding elements of an entry set may fail due to reuse of Map.Entry object in it.tidalwave.messagebus.spi.SimpleMessageBus.dispatchMessage(Class, Object)DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS0--SimpleMessageBus.javaMALICIOUS_CODE00-modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/SimpleMessageBus.java537912b54c1a7f38fe0e385eb369277c8888Overridable method initialize is called from constructor new it.tidalwave.messagebus.spi.SimpleMessageBus(Executor, MessageDelivery).TheseFoolishThings :: MessageBusspotbugsSpotBugsit.tidalwave.messagebus.spi1325LOWSimpleMessageBus.java(88,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method initialize is called from constructor new it.tidalwave.messagebus.spi.SimpleMessageBus(Executor, MessageDelivery).MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--MessageBusAdapterFactory.javaMALICIOUS_CODE00-modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/MessageBusAdapterFactory.java913a23124b07942dd9e763261ca3fc847272Invocation of reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block, in new it.tidalwave.messagebus.impl.spring.MessageBusAdapterFactory$MessageBusListenerAdapter(MessageBusAdapterFactory, Object, Method, Class)TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring1325LOWMessageBusAdapterFactory.java(72,0): DP_DO_INSIDE_DO_PRIVILEGED: MALICIOUS_CODE: Invocation of reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block, in new it.tidalwave.messagebus.impl.spring.MessageBusAdapterFactory$MessageBusListenerAdapter(MessageBusAdapterFactory, Object, Method, Class)DP_DO_INSIDE_DO_PRIVILEGED0--SpringSimpleMessageSubscriberSupport.javaBAD_PRACTICE00-modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberSupport.javafd0baca0ed7888da3db312c0f0cdede14646Exception thrown in class it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport at new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(BeanFactory, Object) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring1325LOWSpringSimpleMessageSubscriberSupport.java(46,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport at new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(BeanFactory, Object) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--SpringSimpleMessageSubscriberAspect.ajMALICIOUS_CODE00-modules/SpringMessageBus/src/main/aspect/it/tidalwave/messagebus/spi/spring/SpringSimpleMessageSubscriberAspect.ajfe4547505a058d6516e74e86fb5fc29d00it.tidalwave.messagebus.spi.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance isn't final but should beTheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.spi.spring1325LOWSpringSimpleMessageSubscriberAspect.aj(0,0): MS_SHOULD_BE_FINAL: MALICIOUS_CODE: it.tidalwave.messagebus.spi.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance isn't final but should beMS_SHOULD_BE_FINAL0--SpringSimpleMessageSubscriberAspect.ajBAD_PRACTICE00-modules/SpringMessageBus/src/main/aspect/it/tidalwave/messagebus/spi/spring/SpringSimpleMessageSubscriberAspect.aj190c7e2614b7ab1790ecbe40be5e74fd11Primitive field it.tidalwave.messagebus.spi.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.spi.spring1325LOWSpringSimpleMessageSubscriberAspect.aj(1,0): PA_PUBLIC_PRIMITIVE_ATTRIBUTE: BAD_PRACTICE: Primitive field it.tidalwave.messagebus.spi.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.PA_PUBLIC_PRIMITIVE_ATTRIBUTE0--AnnotationSpringSystemRoleFactory.javaMALICIOUS_CODE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javae7d9cab325cb9fff901efd6a16082e704747Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1325LOWAnnotationSpringSystemRoleFactory.java(47,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AnnotationSpringSystemRoleFactory.javaMALICIOUS_CODE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javaf2d0c80fd259722b725cb65818bf48ea4747Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1325LOWAnnotationSpringSystemRoleFactory.java(47,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AnnotationSpringSystemRoleFactory.javaSTYLE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javaa1a0838e5f8a8dd2567bb67e281de1b14747Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory()TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1325LOWAnnotationSpringSystemRoleFactory.java(47,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory()RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--DciContextWithAutoThreadBindingAspect.javaMALICIOUS_CODE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.java8221265e527a9496b701f4e3820e17100it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance isn't final but should beTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1325LOWDciContextWithAutoThreadBindingAspect.java(0,0): MS_SHOULD_BE_FINAL: MALICIOUS_CODE: it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance isn't final but should beMS_SHOULD_BE_FINAL0--DciContextWithAutoThreadBindingAspect.javaBAD_PRACTICE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.javac90993cfb0760641904d3060662c815c11Primitive field it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1325LOWDciContextWithAutoThreadBindingAspect.java(1,0): PA_PUBLIC_PRIMITIVE_ATTRIBUTE: BAD_PRACTICE: Primitive field it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.PA_PUBLIC_PRIMITIVE_ATTRIBUTE0--DciContextWithAutoThreadBindingAspect.javaPERFORMANCE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.java28d49b7dd74014600bc6b0c1c2d7abc26868The class it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect$1 could be refactored into a named _static_ inner classTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1325LOWDciContextWithAutoThreadBindingAspect.java(68,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--ClassScanner.javaSTYLE00-modules/SpringRoles/src/main/java/it/tidalwave/util/spring/ClassScanner.java1312ec24ca5bcfe91a21c6b3696bf0a47070Possible null pointer dereference in it.tidalwave.util.spring.ClassScanner.findClasses() due to return value of called methodTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.util.spring1325LOWClassScanner.java(70,0): NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: STYLE: Possible null pointer dereference in it.tidalwave.util.spring.ClassScanner.findClasses() due to return value of called methodNP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE0--BaseTestHelper.javaSTYLE00-modules/TestUtilities/src/main/java/it/tidalwave/util/test/BaseTestHelper.java1421fd46386451eca93ce92d49d3e265116116Possible null pointer dereference in it.tidalwave.util.test.BaseTestHelper.testResourceFor(String) due to return value of called methodTheseFoolishThings :: Test UtilitiesspotbugsSpotBugsit.tidalwave.util.test1325LOWBaseTestHelper.java(116,0): NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: STYLE: Possible null pointer dereference in it.tidalwave.util.test.BaseTestHelper.testResourceFor(String) due to return value of called methodNP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE0--ReflectionUtils.javaMALICIOUS_CODE00-modules/Utilities/src/main/java/it/tidalwave/util/ReflectionUtils.java77d808d30e81a0e03d34e00d01193a5b187187Invocation of reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block, in it.tidalwave.util.ReflectionUtils.injectDependencies(Object, Map)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util1325LOWReflectionUtils.java(187,0): DP_DO_INSIDE_DO_PRIVILEGED: MALICIOUS_CODE: Invocation of reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block, in it.tidalwave.util.ReflectionUtils.injectDependencies(Object, Map)DP_DO_INSIDE_DO_PRIVILEGED0--AsDelegate.javaMALICIOUS_CODE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/AsDelegate.java5d099d8ef542ce57d90da1d750d3be0d6868Overridable method createRoleFactory is called from constructor new it.tidalwave.util.impl.AsDelegate().TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl1325LOWAsDelegate.java(68,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method createRoleFactory is called from constructor new it.tidalwave.util.impl.AsDelegate().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AsDelegate.javaMALICIOUS_CODE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/AsDelegate.java2e4096fe497b49de72e1a6ff76d839d0105105Overridable method createRoleFactory is called from constructor new it.tidalwave.util.impl.AsDelegate(Object, Collection).TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl1325LOWAsDelegate.java(105,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method createRoleFactory is called from constructor new it.tidalwave.util.impl.AsDelegate(Object, Collection).MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--DefaultContextManager.javaPERFORMANCE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/DefaultContextManager.java254fb31b084d3eb6a888475056c4b92f5555The class it.tidalwave.util.impl.DefaultContextManager$1 could be refactored into a named _static_ inner classTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl1325LOWDefaultContextManager.java(55,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.util.impl.DefaultContextManager$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--DefaultPreferencesHandler.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/DefaultPreferencesHandler.javaa0c539ac1e34b5706cb2556060fb8dfd8484Exception thrown in class it.tidalwave.util.impl.DefaultPreferencesHandler at new it.tidalwave.util.impl.DefaultPreferencesHandler() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl1325LOWDefaultPreferencesHandler.java(84,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.util.impl.DefaultPreferencesHandler at new it.tidalwave.util.impl.DefaultPreferencesHandler() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--MappingFinder.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/MappingFinder.java491f0bb9e72b60c321a4e144db1e74900Class it.tidalwave.util.impl.finder.MappingFinder defines non-transient non-serializable instance field decoratorTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder1325LOWMappingFinder.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.impl.finder.MappingFinder defines non-transient non-serializable instance field decoratorSE_BAD_FIELD0--ProviderFinder.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/ProviderFinder.java78620ceffac5909bda9cff745c7c270700Class it.tidalwave.util.impl.finder.ProviderFinder defines non-transient non-serializable instance field supplierTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder1325LOWProviderFinder.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.impl.finder.ProviderFinder defines non-transient non-serializable instance field supplierSE_BAD_FIELD0--SupplierFinder.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/SupplierFinder.javad7ee15815c14bcc4a339b6f44da6235900Class it.tidalwave.util.impl.finder.SupplierFinder defines non-transient non-serializable instance field supplierTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder1325LOWSupplierFinder.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.impl.finder.SupplierFinder defines non-transient non-serializable instance field supplierSE_BAD_FIELD0--DefaultProcessExecutor.javaI18N00-modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java22a61a349131452fc20a230179a88cee464464Use of non-localized String.toUpperCase() or String.toLowerCase() in it.tidalwave.util.spi.DefaultProcessExecutor.isWindows()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWDefaultProcessExecutor.java(464,0): DM_CONVERT_CASE: I18N: Use of non-localized String.toUpperCase() or String.toLowerCase() in it.tidalwave.util.spi.DefaultProcessExecutor.isWindows()DM_CONVERT_CASE0--DefaultProcessExecutor.javaI18N00-modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java546fcec2f3fc51e896f3a93765e3b9a9417417Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor.start(): new java.io.PrintWriter(OutputStream, boolean)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWDefaultProcessExecutor.java(417,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor.start(): new java.io.PrintWriter(OutputStream, boolean)DM_DEFAULT_ENCODING0--DefaultProcessExecutor.javaSTYLE00-modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javacf72bf19c353afd0d889c0f512a33b98440440Useless control flow in it.tidalwave.util.spi.DefaultProcessExecutor.waitForCompletion()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWDefaultProcessExecutor.java(440,0): UCF_USELESS_CONTROL_FLOW: STYLE: Useless control flow in it.tidalwave.util.spi.DefaultProcessExecutor.waitForCompletion()UCF_USELESS_CONTROL_FLOW0--DefaultProcessExecutor.javaI18N00-modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java282979a34723be2e2509ea3ef5ab71c6276276Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read(): new java.io.InputStreamReader(InputStream)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWDefaultProcessExecutor.java(276,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read(): new java.io.InputStreamReader(InputStream)DM_DEFAULT_ENCODING0--DefaultProcessExecutor.javaMT_CORRECTNESS00-modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaa4ff01756de9ea4b0bf187d6935c6579316316Naked notify in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWDefaultProcessExecutor.java(316,0): NN_NAKED_NOTIFY: MT_CORRECTNESS: Naked notify in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()NN_NAKED_NOTIFY0--DefaultProcessExecutor.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaf53c819baaf66f7ccd0135a0b88105ee154154Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWDefaultProcessExecutor.java(154,0): RV_RETURN_VALUE_IGNORED_BAD_PRACTICE: BAD_PRACTICE: Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()RV_RETURN_VALUE_IGNORED_BAD_PRACTICE0--DefaultProcessExecutor.javaMT_CORRECTNESS00-modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java45757508fede6ce813179388b36a1e30249249Unconditional wait in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.waitFor(String)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWDefaultProcessExecutor.java(249,0): UW_UNCOND_WAIT: MT_CORRECTNESS: Unconditional wait in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.waitFor(String)UW_UNCOND_WAIT0--HierarchicFinderSupport.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/spi/HierarchicFinderSupport.java45ae0ac40fa144e84504a769f4190259124124Exception thrown in class it.tidalwave.util.spi.HierarchicFinderSupport at new it.tidalwave.util.spi.HierarchicFinderSupport() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWHierarchicFinderSupport.java(124,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.util.spi.HierarchicFinderSupport at new it.tidalwave.util.spi.HierarchicFinderSupport() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--HierarchicFinderSupport.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/spi/HierarchicFinderSupport.java9f313e4999f382f2f216213fe663a94c111111Exception thrown in class it.tidalwave.util.spi.HierarchicFinderSupport at new it.tidalwave.util.spi.HierarchicFinderSupport(String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1325LOWHierarchicFinderSupport.java(111,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.util.spi.HierarchicFinderSupport at new it.tidalwave.util.spi.HierarchicFinderSupport(String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--ThreadAssertions.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/thread/ThreadAssertions.javacb07dde94c9da84f157f453e8351e3304949Assertion validates method argument at it.tidalwave.util.thread.ThreadAssertions.assertThread(ThreadType). If assertions are disabled, there won't be any argument validation.TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.thread1325LOWThreadAssertions.java(49,0): AA_ASSERTION_OF_ARGUMENTS: BAD_PRACTICE: Assertion validates method argument at it.tidalwave.util.thread.ThreadAssertions.assertThread(ThreadType). If assertions are disabled, there won't be any argument validation.AA_ASSERTION_OF_ARGUMENTS0--Person.javaBAD_PRACTICE00-modules/examples/Data/src/main/java/it/tidalwave/thesefoolishthings/examples/person/Person.java325ac0fb7f8a1c4ea89440d358d845665656Exception thrown in class it.tidalwave.thesefoolishthings.examples.person.Person at new it.tidalwave.thesefoolishthings.examples.person.Person(String, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: Examples :: DataspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.person1325LOWPerson.java(56,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.thesefoolishthings.examples.person.Person at new it.tidalwave.thesefoolishthings.examples.person.Person(String, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--DefaultPersonPresentationControl.javaPERFORMANCE00-modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/DefaultPersonPresentationControl.java18a86cbd5f00673b3b590b02bd3e53e76664Private method it.tidalwave.thesefoolishthings.examples.dci.swing.DefaultPersonPresentationControl.initialize() is never calledTheseFoolishThings :: Examples :: DCI :: SwingspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.dci.swing1325LOWDefaultPersonPresentationControl.java(64,0): UPM_UNCALLED_PRIVATE_METHOD: PERFORMANCE: Private method it.tidalwave.thesefoolishthings.examples.dci.swing.DefaultPersonPresentationControl.initialize() is never calledUPM_UNCALLED_PRIVATE_METHOD0--SwingPersonPresentation.javaBAD_PRACTICE00-modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/swing/SwingPersonPresentation.javaf131a611fe9c5be4316ede9a29b6067f00Class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation defines non-transient non-serializable instance field bindingsTheseFoolishThings :: Examples :: DCI :: SwingspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.dci.swing.swing1325LOWSwingPersonPresentation.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation defines non-transient non-serializable instance field bindingsSE_BAD_FIELD0--SwingPersonPresentation.javaPERFORMANCE00-modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/swing/SwingPersonPresentation.java39a5e79a90d946719198c934fc95d720121121The class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation$1 could be refactored into a named _static_ inner classTheseFoolishThings :: Examples :: DCI :: SwingspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.dci.swing.swing1325LOWSwingPersonPresentation.java(121,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--PersonFinderImpl2b.javaBAD_PRACTICE00-modules/examples/ExtendedFinderExample/src/main/java/it/tidalwave/thesefoolishthings/examples/extendedfinderexample/PersonFinderImpl2b.java1bfba185d5f92911f032bc1722c26fdf00Class it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2b defines non-transient non-serializable instance field statusTheseFoolishThings :: Examples :: Finder :: Extended FinderspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.extendedfinderexample1325LOWPersonFinderImpl2b.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2b defines non-transient non-serializable instance field statusSE_BAD_FIELD0--JpaFinder.javaBAD_PRACTICE00-modules/examples/JPAFinderExample/src/main/java/it/tidalwave/thesefoolishthings/examples/jpafinderexample/impl/JpaFinder.java8f1199a0a095a48c8c16127db9bdcd909999Exception thrown in class it.tidalwave.thesefoolishthings.examples.jpafinderexample.impl.JpaFinder at new it.tidalwave.thesefoolishthings.examples.jpafinderexample.impl.JpaFinder(Class, Function, TxManager) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: Examples :: Finder :: JPA FinderspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.jpafinderexample.impl1325LOWJpaFinder.java(99,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.thesefoolishthings.examples.jpafinderexample.impl.JpaFinder at new it.tidalwave.thesefoolishthings.examples.jpafinderexample.impl.JpaFinder(Class, Function, TxManager) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW4141 warnings (low: 41)