0--SimpleMessageBus.javaBAD_PRACTICE00-modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/SimpleMessageBus.javadedc8406d099b7891eac4112cb475dfa144144Adding elements of an entry set may fail due to reuse of Map.Entry object in it.tidalwave.messagebus.spi.SimpleMessageBus.dispatchMessage(Class, Object)TheseFoolishThings :: MessageBusspotbugsSpotBugsit.tidalwave.messagebus.spi1326LOWSimpleMessageBus.java(144,0): DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS: BAD_PRACTICE: Adding elements of an entry set may fail due to reuse of Map.Entry object in it.tidalwave.messagebus.spi.SimpleMessageBus.dispatchMessage(Class, Object)DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS0--SpringSimpleMessageSubscriberSupport.javaBAD_PRACTICE00-modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberSupport.javafd0baca0ed7888da3db312c0f0cdede14646Exception thrown in class it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport at new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(BeanFactory, Object) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring1326LOWSpringSimpleMessageSubscriberSupport.java(46,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport at new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(BeanFactory, Object) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--SpringSimpleMessageSubscriberAspect.ajBAD_PRACTICE00-modules/SpringMessageBus/src/main/aspect/it/tidalwave/messagebus/spi/spring/SpringSimpleMessageSubscriberAspect.aj190c7e2614b7ab1790ecbe40be5e74fd11Primitive field it.tidalwave.messagebus.spi.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.spi.spring1326LOWSpringSimpleMessageSubscriberAspect.aj(1,0): PA_PUBLIC_PRIMITIVE_ATTRIBUTE: BAD_PRACTICE: Primitive field it.tidalwave.messagebus.spi.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.PA_PUBLIC_PRIMITIVE_ATTRIBUTE0--DciContextWithAutoThreadBindingAspect.javaBAD_PRACTICE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.javac90993cfb0760641904d3060662c815c11Primitive field it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1326LOWDciContextWithAutoThreadBindingAspect.java(1,0): PA_PUBLIC_PRIMITIVE_ATTRIBUTE: BAD_PRACTICE: Primitive field it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.PA_PUBLIC_PRIMITIVE_ATTRIBUTE0--DefaultPreferencesHandler.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/DefaultPreferencesHandler.javaa0c539ac1e34b5706cb2556060fb8dfd8484Exception thrown in class it.tidalwave.util.impl.DefaultPreferencesHandler at new it.tidalwave.util.impl.DefaultPreferencesHandler() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl1326LOWDefaultPreferencesHandler.java(84,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.util.impl.DefaultPreferencesHandler at new it.tidalwave.util.impl.DefaultPreferencesHandler() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--MappingFinder.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/MappingFinder.java83aaacf49bbb74ec6fd2f7f70fd09f1100Class it.tidalwave.util.impl.finder.MappingFinder defines non-transient non-serializable instance field mapperTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder1326LOWMappingFinder.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.impl.finder.MappingFinder defines non-transient non-serializable instance field mapperSE_BAD_FIELD0--ProviderFinder.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/ProviderFinder.java78620ceffac5909bda9cff745c7c270700Class it.tidalwave.util.impl.finder.ProviderFinder defines non-transient non-serializable instance field supplierTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder1326LOWProviderFinder.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.impl.finder.ProviderFinder defines non-transient non-serializable instance field supplierSE_BAD_FIELD0--SupplierFinder.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/SupplierFinder.javad7ee15815c14bcc4a339b6f44da6235900Class it.tidalwave.util.impl.finder.SupplierFinder defines non-transient non-serializable instance field supplierTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder1326LOWSupplierFinder.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.impl.finder.SupplierFinder defines non-transient non-serializable instance field supplierSE_BAD_FIELD0--DefaultProcessExecutor.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaf53c819baaf66f7ccd0135a0b88105ee154154Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1326LOWDefaultProcessExecutor.java(154,0): RV_RETURN_VALUE_IGNORED_BAD_PRACTICE: BAD_PRACTICE: Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()RV_RETURN_VALUE_IGNORED_BAD_PRACTICE0--HierarchicFinderSupport.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/spi/HierarchicFinderSupport.java45ae0ac40fa144e84504a769f4190259119119Exception thrown in class it.tidalwave.util.spi.HierarchicFinderSupport at new it.tidalwave.util.spi.HierarchicFinderSupport() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1326LOWHierarchicFinderSupport.java(119,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.util.spi.HierarchicFinderSupport at new it.tidalwave.util.spi.HierarchicFinderSupport() will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--HierarchicFinderSupport.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/spi/HierarchicFinderSupport.java9f313e4999f382f2f216213fe663a94c106106Exception thrown in class it.tidalwave.util.spi.HierarchicFinderSupport at new it.tidalwave.util.spi.HierarchicFinderSupport(String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi1326LOWHierarchicFinderSupport.java(106,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.util.spi.HierarchicFinderSupport at new it.tidalwave.util.spi.HierarchicFinderSupport(String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--ThreadAssertions.javaBAD_PRACTICE00-modules/Utilities/src/main/java/it/tidalwave/util/thread/ThreadAssertions.javacb07dde94c9da84f157f453e8351e3304949Assertion validates method argument at it.tidalwave.util.thread.ThreadAssertions.assertThread(ThreadType). If assertions are disabled, there won't be any argument validation.TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.thread1326LOWThreadAssertions.java(49,0): AA_ASSERTION_OF_ARGUMENTS: BAD_PRACTICE: Assertion validates method argument at it.tidalwave.util.thread.ThreadAssertions.assertThread(ThreadType). If assertions are disabled, there won't be any argument validation.AA_ASSERTION_OF_ARGUMENTS0--Person.javaBAD_PRACTICE00-modules/examples/Data/src/main/java/it/tidalwave/thesefoolishthings/examples/person/Person.java325ac0fb7f8a1c4ea89440d358d845665656Exception thrown in class it.tidalwave.thesefoolishthings.examples.person.Person at new it.tidalwave.thesefoolishthings.examples.person.Person(String, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: Examples :: DataspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.person1326LOWPerson.java(56,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.thesefoolishthings.examples.person.Person at new it.tidalwave.thesefoolishthings.examples.person.Person(String, String) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW0--SwingPersonPresentation.javaBAD_PRACTICE00-modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/swing/SwingPersonPresentation.javaf131a611fe9c5be4316ede9a29b6067f00Class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation defines non-transient non-serializable instance field bindingsTheseFoolishThings :: Examples :: DCI :: SwingspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.dci.swing.swing1326LOWSwingPersonPresentation.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation defines non-transient non-serializable instance field bindingsSE_BAD_FIELD0--PersonFinderImpl2b.javaBAD_PRACTICE00-modules/examples/ExtendedFinderExample/src/main/java/it/tidalwave/thesefoolishthings/examples/extendedfinderexample/PersonFinderImpl2b.java1bfba185d5f92911f032bc1722c26fdf00Class it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2b defines non-transient non-serializable instance field statusTheseFoolishThings :: Examples :: Finder :: Extended FinderspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.extendedfinderexample1326LOWPersonFinderImpl2b.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2b defines non-transient non-serializable instance field statusSE_BAD_FIELD0--JpaFinder.javaBAD_PRACTICE00-modules/examples/JPAFinderExample/src/main/java/it/tidalwave/thesefoolishthings/examples/jpafinderexample/impl/JpaFinder.java8f1199a0a095a48c8c16127db9bdcd909999Exception thrown in class it.tidalwave.thesefoolishthings.examples.jpafinderexample.impl.JpaFinder at new it.tidalwave.thesefoolishthings.examples.jpafinderexample.impl.JpaFinder(Class, Function, TxManager) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.TheseFoolishThings :: Examples :: Finder :: JPA FinderspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.jpafinderexample.impl1326LOWJpaFinder.java(99,0): CT_CONSTRUCTOR_THROW: BAD_PRACTICE: Exception thrown in class it.tidalwave.thesefoolishthings.examples.jpafinderexample.impl.JpaFinder at new it.tidalwave.thesefoolishthings.examples.jpafinderexample.impl.JpaFinder(Class, Function, TxManager) will leave the constructor. The object under construction remains partially initialized and may be vulnerable to Finalizer attacks.CT_CONSTRUCTOR_THROW1616 warnings (low: 16)