0--AnnotationSpringSystemRoleFactory.javaMALICIOUS_CODE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javae7d9cab325cb9fff901efd6a16082e704747Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1326LOWAnnotationSpringSystemRoleFactory.java(47,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AnnotationSpringSystemRoleFactory.javaMALICIOUS_CODE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javaf2d0c80fd259722b725cb65818bf48ea4747Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1326LOWAnnotationSpringSystemRoleFactory.java(47,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AnnotationSpringSystemRoleFactory.javaSTYLE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javaa1a0838e5f8a8dd2567bb67e281de1b14747Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory()TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1326LOWAnnotationSpringSystemRoleFactory.java(47,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory()RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--DciContextWithAutoThreadBindingAspect.javaMALICIOUS_CODE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.java8221265e527a9496b701f4e3820e17100it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance isn't final but should beTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1326LOWDciContextWithAutoThreadBindingAspect.java(0,0): MS_SHOULD_BE_FINAL: MALICIOUS_CODE: it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance isn't final but should beMS_SHOULD_BE_FINAL0--DciContextWithAutoThreadBindingAspect.javaBAD_PRACTICE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.javac90993cfb0760641904d3060662c815c11Primitive field it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1326LOWDciContextWithAutoThreadBindingAspect.java(1,0): PA_PUBLIC_PRIMITIVE_ATTRIBUTE: BAD_PRACTICE: Primitive field it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance is public and set from inside the class, which makes it too exposed. Consider making it private to limit external accessibility.PA_PUBLIC_PRIMITIVE_ATTRIBUTE0--DciContextWithAutoThreadBindingAspect.javaPERFORMANCE00-modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.java28d49b7dd74014600bc6b0c1c2d7abc26868The class it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect$1 could be refactored into a named _static_ inner classTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi1326LOWDciContextWithAutoThreadBindingAspect.java(68,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--ClassScanner.javaSTYLE00-modules/SpringRoles/src/main/java/it/tidalwave/util/spring/ClassScanner.java1312ec24ca5bcfe91a21c6b3696bf0a47070Possible null pointer dereference in it.tidalwave.util.spring.ClassScanner.findClasses() due to return value of called methodTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.util.spring1326LOWClassScanner.java(70,0): NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: STYLE: Possible null pointer dereference in it.tidalwave.util.spring.ClassScanner.findClasses() due to return value of called methodNP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE77 warnings (low: 7)