0--CollaborationAwareMessageBusAdapter.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Actors/src/main/java/it/tidalwave/actor/impl/CollaborationAwareMessageBusAdapter.javad2d09f575203d58ca6dc11a97fe1ab2f137137it.tidalwave.actor.impl.CollaborationAwareMessageBusAdapter.registerCollaborationListener(Method) uses the same code for two branchesTheseFoolishThings :: ActorsspotbugsSpotBugsit.tidalwave.actor.impl478LOWCollaborationAwareMessageBusAdapter.java(137,0): DB_DUPLICATE_BRANCHES: STYLE: it.tidalwave.actor.impl.CollaborationAwareMessageBusAdapter.registerCollaborationListener(Method) uses the same code for two branchesDB_DUPLICATE_BRANCHES0--ExecutorWithPriority.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Actors/src/main/java/it/tidalwave/actor/impl/ExecutorWithPriority.java47f5fabdcbbf82f7cbc1e7f1edd289927373The class it.tidalwave.actor.impl.ExecutorWithPriority$2 could be refactored into a named _static_ inner classTheseFoolishThings :: ActorsspotbugsSpotBugsit.tidalwave.actor.impl478LOWExecutorWithPriority.java(73,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.actor.impl.ExecutorWithPriority$2 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--ExecutorWithPriority.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Actors/src/main/java/it/tidalwave/actor/impl/ExecutorWithPriority.java37846ee1c653c72d8b3a8140d78fb389106106The class it.tidalwave.actor.impl.ExecutorWithPriority$3 could be refactored into a named _static_ inner classTheseFoolishThings :: ActorsspotbugsSpotBugsit.tidalwave.actor.impl478LOWExecutorWithPriority.java(106,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.actor.impl.ExecutorWithPriority$3 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--MessageBusAdapterFactory.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/MessageBusAdapterFactory.java913a23124b07942dd9e763261ca3fc847575Invocation of reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block, in new it.tidalwave.messagebus.impl.spring.MessageBusAdapterFactory$MessageBusListenerAdapter(MessageBusAdapterFactory, Object, Method, Class)TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring478LOWMessageBusAdapterFactory.java(75,0): DP_DO_INSIDE_DO_PRIVILEGED: MALICIOUS_CODE: Invocation of reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block, in new it.tidalwave.messagebus.impl.spring.MessageBusAdapterFactory$MessageBusListenerAdapter(MessageBusAdapterFactory, Object, Method, Class)DP_DO_INSIDE_DO_PRIVILEGED0--SpringSimpleMessageSubscriberAspect.ajMALICIOUS_CODE00-it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberAspect.aj945c612de87a60bfe1c843d80952bb1000it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance isn't final but should beTheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring478LOWSpringSimpleMessageSubscriberAspect.aj(0,0): MS_SHOULD_BE_FINAL: MALICIOUS_CODE: it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance isn't final but should beMS_SHOULD_BE_FINAL0--SpringSimpleMessageSubscriberSupport.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberSupport.javac8bf8cf56da342f70f7a5987591146b45151Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object).TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring481LOWSpringSimpleMessageSubscriberSupport.java(51,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object).MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--SpringSimpleMessageSubscriberSupport.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberSupport.java2551bd92f75db7ab85940d221acd60ba5151Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object).TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring481LOWSpringSimpleMessageSubscriberSupport.java(51,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object).MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--SpringSimpleMessageSubscriberSupport.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberSupport.javac0ed73ccf8503779c71bf94acc367a9a5551Non-null field beanFactory is not initialized by new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object)TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring478NORMALSpringSimpleMessageSubscriberSupport.java(51,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field beanFactory is not initialized by new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object)NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SpringSimpleMessageSubscriberSupport.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberSupport.java688c861135187c1691e2fbed36b21fb55151Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object)TheseFoolishThings :: MessageBus :: SpringspotbugsSpotBugsit.tidalwave.messagebus.impl.spring478LOWSpringSimpleMessageSubscriberSupport.java(51,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object)RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--RoundRobinAsyncMessageDelivery.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/RoundRobinAsyncMessageDelivery.java953ef9ecc082ff2a51996f531d2a80226046Non-null field messageBusSupport is not initialized by new it.tidalwave.messagebus.spi.RoundRobinAsyncMessageDelivery()TheseFoolishThings :: MessageBusspotbugsSpotBugsit.tidalwave.messagebus.spi478NORMALRoundRobinAsyncMessageDelivery.java(46,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field messageBusSupport is not initialized by new it.tidalwave.messagebus.spi.RoundRobinAsyncMessageDelivery()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SimpleAsyncMessageDelivery.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/SimpleAsyncMessageDelivery.java53040b7c3286dd4fc80dba90374725714242Non-null field messageBusSupport is not initialized by new it.tidalwave.messagebus.spi.SimpleAsyncMessageDelivery()TheseFoolishThings :: MessageBusspotbugsSpotBugsit.tidalwave.messagebus.spi478NORMALSimpleAsyncMessageDelivery.java(42,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field messageBusSupport is not initialized by new it.tidalwave.messagebus.spi.SimpleAsyncMessageDelivery()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SimpleMessageBus.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/SimpleMessageBus.javadedc8406d099b7891eac4112cb475dfa161161Adding elements of an entry set may fail due to reuse of Map.Entry object in it.tidalwave.messagebus.spi.SimpleMessageBus.dispatchMessage(Class, Object)TheseFoolishThings :: MessageBusspotbugsSpotBugsit.tidalwave.messagebus.spi478LOWSimpleMessageBus.java(161,0): DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS: BAD_PRACTICE: Adding elements of an entry set may fail due to reuse of Map.Entry object in it.tidalwave.messagebus.spi.SimpleMessageBus.dispatchMessage(Class, Object)DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS0--SimpleMessageBus.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/SimpleMessageBus.java537912b54c1a7f38fe0e385eb369277c9595Overridable method initialize is called from constructor new it.tidalwave.messagebus.spi.SimpleMessageBus(Executor, MessageDelivery).TheseFoolishThings :: MessageBusspotbugsSpotBugsit.tidalwave.messagebus.spi481LOWSimpleMessageBus.java(95,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method initialize is called from constructor new it.tidalwave.messagebus.spi.SimpleMessageBus(Executor, MessageDelivery).MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AnnotationSpringSystemRoleFactory.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javae7d9cab325cb9fff901efd6a16082e705050Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi546LOWAnnotationSpringSystemRoleFactory.java(50,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method ajc$afterReturning$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$2$1ea6722c is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AnnotationSpringSystemRoleFactory.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javaf2d0c80fd259722b725cb65818bf48ea5050Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi546LOWAnnotationSpringSystemRoleFactory.java(50,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method ajc$before$org_springframework_beans_factory_aspectj_AbstractDependencyInjectionAspect$1$e854fa65 is called from constructor new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AnnotationSpringSystemRoleFactory.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.java4f6e8a5d24378cff423a3a8e11cb3c025050Non-null field beanFactory is not initialized by new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory()TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi546NORMALAnnotationSpringSystemRoleFactory.java(50,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field beanFactory is not initialized by new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--AnnotationSpringSystemRoleFactory.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringSystemRoleFactory.javaa1a0838e5f8a8dd2567bb67e281de1b15050Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory()TheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi546LOWAnnotationSpringSystemRoleFactory.java(50,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.AnnotationSpringSystemRoleFactory()RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--DciContextWithAutoThreadBindingAspect.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.java8221265e527a9496b701f4e3820e17100it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance isn't final but should beTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi478LOWDciContextWithAutoThreadBindingAspect.java(0,0): MS_SHOULD_BE_FINAL: MALICIOUS_CODE: it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance isn't final but should beMS_SHOULD_BE_FINAL0--DciContextWithAutoThreadBindingAspect.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.java28d49b7dd74014600bc6b0c1c2d7abc26969The class it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect$1 could be refactored into a named _static_ inner classTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.role.spring.spi478LOWDciContextWithAutoThreadBindingAspect.java(69,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--ClassScanner.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/util/spring/ClassScanner.java1312ec24ca5bcfe91a21c6b3696bf0a47373Possible null pointer dereference in it.tidalwave.util.spring.ClassScanner.findClasses() due to return value of called methodTheseFoolishThings :: Roles :: SpringspotbugsSpotBugsit.tidalwave.util.spring547LOWClassScanner.java(73,0): NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: STYLE: Possible null pointer dereference in it.tidalwave.util.spring.ClassScanner.findClasses() due to return value of called methodNP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE0--BooleanBoundFunctionSupport.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/function/BooleanBoundFunctionSupport.java7e2c04081b3015b1edb0c3b986f54a286767Overridable method function is called from constructor new it.tidalwave.role.ui.function.BooleanBoundFunctionSupport(ChangingSource[]).TheseFoolishThings :: RolesspotbugsSpotBugsit.tidalwave.role.ui.function481LOWBooleanBoundFunctionSupport.java(67,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method function is called from constructor new it.tidalwave.role.ui.function.BooleanBoundFunctionSupport(ChangingSource[]).MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--WeakCopyFunctionSupport.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/function/WeakCopyFunctionSupport.javaa652e9a29a77fcd074d7d6d0e2f671ff5049Non-null field targetValue is not initialized by new it.tidalwave.role.ui.function.WeakCopyFunctionSupport(ChangingSource)TheseFoolishThings :: RolesspotbugsSpotBugsit.tidalwave.role.ui.function478NORMALWeakCopyFunctionSupport.java(49,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field targetValue is not initialized by new it.tidalwave.role.ui.function.WeakCopyFunctionSupport(ChangingSource)NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--AsDisplayableComparator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/AsDisplayableComparator.javad674a5e33451f39c0618fc9b4a1823225944it.tidalwave.role.ui.impl.AsDisplayableComparator implements Comparator but not SerializableTheseFoolishThings :: RolesspotbugsSpotBugsit.tidalwave.role.ui.impl478LOWAsDisplayableComparator.java(44,0): SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: BAD_PRACTICE: it.tidalwave.role.ui.impl.AsDisplayableComparator implements Comparator but not SerializableSE_COMPARATOR_SHOULD_BE_SERIALIZABLE0--DefaultPresentationModel.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/DefaultPresentationModel.java59bb6d0144e44c2b3363e412ee525442110110Redundant nullcheck of role, which is known to be non-null in it.tidalwave.role.ui.impl.DefaultPresentationModel.maybeAs(Class)TheseFoolishThings :: RolesspotbugsSpotBugsit.tidalwave.role.ui.impl531LOWDefaultPresentationModel.java(110,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of role, which is known to be non-null in it.tidalwave.role.ui.impl.DefaultPresentationModel.maybeAs(Class)RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--DisplayableComparator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/DisplayableComparator.java61f04bbab317a730ab8369e0800d2a35843it.tidalwave.role.ui.impl.DisplayableComparator implements Comparator but not SerializableTheseFoolishThings :: RolesspotbugsSpotBugsit.tidalwave.role.ui.impl478LOWDisplayableComparator.java(43,0): SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: BAD_PRACTICE: it.tidalwave.role.ui.impl.DisplayableComparator implements Comparator but not SerializableSE_COMPARATOR_SHOULD_BE_SERIALIZABLE0--BaseTestHelper.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/TestUtilities/src/main/java/it/tidalwave/util/test/BaseTestHelper.java1421fd46386451eca93ce92d49d3e265124124Possible null pointer dereference in it.tidalwave.util.test.BaseTestHelper.testResourceFor(String) due to return value of called methodTheseFoolishThings :: Test UtilitiesspotbugsSpotBugsit.tidalwave.util.test547LOWBaseTestHelper.java(124,0): NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: STYLE: Possible null pointer dereference in it.tidalwave.util.test.BaseTestHelper.testResourceFor(String) due to return value of called methodNP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE0--AsDelegate.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/role/impl/AsDelegate.java5d870cc1b5cd713568d6636ef559aae27171Overridable method createRoleFactory is called from constructor new it.tidalwave.role.impl.AsDelegate().TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.role.impl546LOWAsDelegate.java(71,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method createRoleFactory is called from constructor new it.tidalwave.role.impl.AsDelegate().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--AsDelegate.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/role/impl/AsDelegate.javaf6f3cc9c2a6211efe0f77ce30776fb4d114114Overridable method createRoleFactory is called from constructor new it.tidalwave.role.impl.AsDelegate(Object, Collection).TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.role.impl546LOWAsDelegate.java(114,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method createRoleFactory is called from constructor new it.tidalwave.role.impl.AsDelegate(Object, Collection).MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--DefaultContextManager.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/role/impl/DefaultContextManager.javab2c3aa96765d6f3081cf9ed54dee449c5656The class it.tidalwave.role.impl.DefaultContextManager$1 could be refactored into a named _static_ inner classTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.role.impl546LOWDefaultContextManager.java(56,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.impl.DefaultContextManager$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--ServiceLoaderLocator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/role/impl/ServiceLoaderLocator.java1808ed7b2ded2037f426d6180915ab8d8686Format string should use %n rather than \n in it.tidalwave.role.impl.ServiceLoaderLocator.findService(Class)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.role.impl608LOWServiceLoaderLocator.java(86,0): VA_FORMAT_STRING_USES_NEWLINE: BAD_PRACTICE: Format string should use %n rather than \n in it.tidalwave.role.impl.ServiceLoaderLocator.findService(Class)VA_FORMAT_STRING_USES_NEWLINE0--ReflectionUtils.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/ReflectionUtils.java77d808d30e81a0e03d34e00d01193a5b179179Invocation of reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block, in it.tidalwave.util.ReflectionUtils.injectDependencies(Object, Map)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util546LOWReflectionUtils.java(179,0): DP_DO_INSIDE_DO_PRIVILEGED: MALICIOUS_CODE: Invocation of reflect.Field.setAccessible(boolean), which should be invoked from within a doPrivileged block, in it.tidalwave.util.ReflectionUtils.injectDependencies(Object, Map)DP_DO_INSIDE_DO_PRIVILEGED0--ReflectionUtils.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/ReflectionUtils.java10b6c30d77fba5e675929d6fadf1a5d7676Possible null pointer dereference in it.tidalwave.util.ReflectionUtils.getTypeArguments(Class, Class) due to return value of called methodTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util546LOWReflectionUtils.java(76,0): NP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE: STYLE: Possible null pointer dereference in it.tidalwave.util.ReflectionUtils.getTypeArguments(Class, Class) due to return value of called methodNP_NULL_ON_SOME_PATH_FROM_RETURN_VALUE0--ShortNames.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/ShortNames.java7be4ca9057d0e00346e79a3f88d4648d155155Exception is caught when Exception is not thrown in it.tidalwave.util.ShortNames.shortId(Object)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util547LOWShortNames.java(155,0): REC_CATCH_EXCEPTION: STYLE: Exception is caught when Exception is not thrown in it.tidalwave.util.ShortNames.shortId(Object)REC_CATCH_EXCEPTION0--StreamUtils.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/StreamUtils.java7fca9fcbc49ac7127f3739fd533f3aa4141141Random object created and used only once in it.tidalwave.util.StreamUtils.randomLocalDateTimeStream(long, LocalDateTime, LocalDateTime)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util608LOWStreamUtils.java(141,0): DMI_RANDOM_USED_ONLY_ONCE: BAD_PRACTICE: Random object created and used only once in it.tidalwave.util.StreamUtils.randomLocalDateTimeStream(long, LocalDateTime, LocalDateTime)DMI_RANDOM_USED_ONLY_ONCE0--DefaultPreferencesHandler.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/impl/DefaultPreferencesHandler.java63bc3860945c376aeb5dd62f353873c66767Use of non-localized String.toUpperCase() or String.toLowerCase() in new it.tidalwave.util.impl.DefaultPreferencesHandler()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl546LOWDefaultPreferencesHandler.java(67,0): DM_CONVERT_CASE: I18N: Use of non-localized String.toUpperCase() or String.toLowerCase() in new it.tidalwave.util.impl.DefaultPreferencesHandler()DM_CONVERT_CASE0--DefaultPreferencesHandler.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/impl/DefaultPreferencesHandler.javab0fae63d5097a179c790dd83f24c81c19393Format string should use %n rather than \n in new it.tidalwave.util.impl.DefaultPreferencesHandler()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl608LOWDefaultPreferencesHandler.java(93,0): VA_FORMAT_STRING_USES_NEWLINE: BAD_PRACTICE: Format string should use %n rather than \n in new it.tidalwave.util.impl.DefaultPreferencesHandler()VA_FORMAT_STRING_USES_NEWLINE0--DefaultPreferencesHandler.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/impl/DefaultPreferencesHandler.java4a8025d870b311a2d7060fd305f32c1d9494Format string should use %n rather than \n in new it.tidalwave.util.impl.DefaultPreferencesHandler()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl608LOWDefaultPreferencesHandler.java(94,0): VA_FORMAT_STRING_USES_NEWLINE: BAD_PRACTICE: Format string should use %n rather than \n in new it.tidalwave.util.impl.DefaultPreferencesHandler()VA_FORMAT_STRING_USES_NEWLINE0--MappingFinder.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/MappingFinder.javafa2ffc2350e5e3e7dc76ba596541a74600The field it.tidalwave.util.impl.finder.MappingFinder.delegate is transient but isn't set by deserializationTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder546LOWMappingFinder.java(0,0): SE_TRANSIENT_FIELD_NOT_RESTORED: BAD_PRACTICE: The field it.tidalwave.util.impl.finder.MappingFinder.delegate is transient but isn't set by deserializationSE_TRANSIENT_FIELD_NOT_RESTORED0--MappingFinder.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/MappingFinder.java2ee9b4e52312d8a5f7e746397b35873800The field it.tidalwave.util.impl.finder.MappingFinder.decorator is transient but isn't set by deserializationTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder546LOWMappingFinder.java(0,0): SE_TRANSIENT_FIELD_NOT_RESTORED: BAD_PRACTICE: The field it.tidalwave.util.impl.finder.MappingFinder.decorator is transient but isn't set by deserializationSE_TRANSIENT_FIELD_NOT_RESTORED0--ProviderFinder.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/ProviderFinder.java78620ceffac5909bda9cff745c7c270700Class it.tidalwave.util.impl.finder.ProviderFinder defines non-transient non-serializable instance field supplierTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder546LOWProviderFinder.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.impl.finder.ProviderFinder defines non-transient non-serializable instance field supplierSE_BAD_FIELD0--SupplierFinder.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/impl/finder/SupplierFinder.javad7ee15815c14bcc4a339b6f44da6235900Class it.tidalwave.util.impl.finder.SupplierFinder defines non-transient non-serializable instance field supplierTheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.impl.finder546LOWSupplierFinder.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.impl.finder.SupplierFinder defines non-transient non-serializable instance field supplierSE_BAD_FIELD0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java22a61a349131452fc20a230179a88cee483483Use of non-localized String.toUpperCase() or String.toLowerCase() in it.tidalwave.util.spi.DefaultProcessExecutor.isWindows()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi478LOWDefaultProcessExecutor.java(483,0): DM_CONVERT_CASE: I18N: Use of non-localized String.toUpperCase() or String.toLowerCase() in it.tidalwave.util.spi.DefaultProcessExecutor.isWindows()DM_CONVERT_CASE0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java546fcec2f3fc51e896f3a93765e3b9a9428428Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor.start(): new java.io.PrintWriter(OutputStream, boolean)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi478LOWDefaultProcessExecutor.java(428,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor.start(): new java.io.PrintWriter(OutputStream, boolean)DM_DEFAULT_ENCODING0--DefaultProcessExecutor.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javacf72bf19c353afd0d889c0f512a33b98455455Useless control flow in it.tidalwave.util.spi.DefaultProcessExecutor.waitForCompletion()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi478LOWDefaultProcessExecutor.java(455,0): UCF_USELESS_CONTROL_FLOW: STYLE: Useless control flow in it.tidalwave.util.spi.DefaultProcessExecutor.waitForCompletion()UCF_USELESS_CONTROL_FLOW0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java282979a34723be2e2509ea3ef5ab71c6279279Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read(): new java.io.InputStreamReader(InputStream)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi478LOWDefaultProcessExecutor.java(279,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read(): new java.io.InputStreamReader(InputStream)DM_DEFAULT_ENCODING0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaa4ff01756de9ea4b0bf187d6935c6579319319Naked notify in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi478LOWDefaultProcessExecutor.java(319,0): NN_NAKED_NOTIFY: MT_CORRECTNESS: Naked notify in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()NN_NAKED_NOTIFY0--DefaultProcessExecutor.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaf53c819baaf66f7ccd0135a0b88105ee157157Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi478LOWDefaultProcessExecutor.java(157,0): RV_RETURN_VALUE_IGNORED_BAD_PRACTICE: BAD_PRACTICE: Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()RV_RETURN_VALUE_IGNORED_BAD_PRACTICE0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java45757508fede6ce813179388b36a1e30252252Unconditional wait in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.waitFor(String)TheseFoolishThings :: UtilitiesspotbugsSpotBugsit.tidalwave.util.spi478LOWDefaultProcessExecutor.java(252,0): UW_UNCOND_WAIT: MT_CORRECTNESS: Unconditional wait in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.waitFor(String)UW_UNCOND_WAIT0--DciMarshalXStreamExample.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciMarshalXStreamExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/marshal/xstream/DciMarshalXStreamExample.javab7578c7fe9b3ecd553b67dbaa05b3f765959Non-null field contextManager is not initialized by new it.tidalwave.thesefoolishthings.examples.dci.marshal.xstream.DciMarshalXStreamExample()TheseFoolishThings :: Examples :: DCI :: Marshal XStreamspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.dci.marshal.xstream478NORMALDciMarshalXStreamExample.java(59,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field contextManager is not initialized by new it.tidalwave.thesefoolishthings.examples.dci.marshal.xstream.DciMarshalXStreamExample()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--DciMarshalXStreamExample.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciMarshalXStreamExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/marshal/xstream/DciMarshalXStreamExample.java653c8b5c13e56630cbdc0a4eaa19bb97106103Private method it.tidalwave.thesefoolishthings.examples.dci.marshal.xstream.DciMarshalXStreamExample.alternateSyntax() is never calledTheseFoolishThings :: Examples :: DCI :: Marshal XStreamspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.dci.marshal.xstream488LOWDciMarshalXStreamExample.java(103,0): UPM_UNCALLED_PRIVATE_METHOD: PERFORMANCE: Private method it.tidalwave.thesefoolishthings.examples.dci.marshal.xstream.DciMarshalXStreamExample.alternateSyntax() is never calledUPM_UNCALLED_PRIVATE_METHOD0--SwingPersonPresentation.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/swing/SwingPersonPresentation.javaf131a611fe9c5be4316ede9a29b6067f00Class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation defines non-transient non-serializable instance field bindingsTheseFoolishThings :: Examples :: DCI :: SwingspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.dci.swing.swing478LOWSwingPersonPresentation.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation defines non-transient non-serializable instance field bindingsSE_BAD_FIELD0--SwingPersonPresentation.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/swing/SwingPersonPresentation.java39a5e79a90d946719198c934fc95d720123123The class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation$1 could be refactored into a named _static_ inner classTheseFoolishThings :: Examples :: DCI :: SwingspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.dci.swing.swing478LOWSwingPersonPresentation.java(123,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--PersonFinderImpl2a.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/ExtendedFinderExample/src/main/java/it/tidalwave/thesefoolishthings/examples/extendedfinderexample/PersonFinderImpl2a.javafabac0e6beb243e8f6073c2b107ccbec00Class it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2a defines non-transient non-serializable instance field personsTheseFoolishThings :: Examples :: Finder :: Extended FinderspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.extendedfinderexample478LOWPersonFinderImpl2a.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2a defines non-transient non-serializable instance field personsSE_BAD_FIELD0--PersonFinderImpl2a.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/ExtendedFinderExample/src/main/java/it/tidalwave/thesefoolishthings/examples/extendedfinderexample/PersonFinderImpl2a.javace7c8078be2898f81c8cf6ef9a3df77110556it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2a is Serializable; consider declaring a serialVersionUIDTheseFoolishThings :: Examples :: Finder :: Extended FinderspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.extendedfinderexample478LOWPersonFinderImpl2a.java(56,0): SE_NO_SERIALVERSIONID: BAD_PRACTICE: it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2a is Serializable; consider declaring a serialVersionUIDSE_NO_SERIALVERSIONID0--PersonFinderImpl2b.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/ExtendedFinderExample/src/main/java/it/tidalwave/thesefoolishthings/examples/extendedfinderexample/PersonFinderImpl2b.java1bfba185d5f92911f032bc1722c26fdf00Class it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2b defines non-transient non-serializable instance field statusTheseFoolishThings :: Examples :: Finder :: Extended FinderspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.extendedfinderexample478LOWPersonFinderImpl2b.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2b defines non-transient non-serializable instance field statusSE_BAD_FIELD0--PersonFinderImpl2b.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/ExtendedFinderExample/src/main/java/it/tidalwave/thesefoolishthings/examples/extendedfinderexample/PersonFinderImpl2b.java1c972e50851ea48f59440f9b01f7fbc711774it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2b is Serializable; consider declaring a serialVersionUIDTheseFoolishThings :: Examples :: Finder :: Extended FinderspotbugsSpotBugsit.tidalwave.thesefoolishthings.examples.extendedfinderexample478LOWPersonFinderImpl2b.java(74,0): SE_NO_SERIALVERSIONID: BAD_PRACTICE: it.tidalwave.thesefoolishthings.examples.extendedfinderexample.PersonFinderImpl2b is Serializable; consider declaring a serialVersionUIDSE_NO_SERIALVERSIONID5656 warnings (normal: 6, low: 50)