0--AsDisplayableComparator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/AsDisplayableComparator.javad674a5e33451f39c0618fc9b4a1823225944it.tidalwave.role.ui.impl.AsDisplayableComparator implements Comparator but not SerializableTheseFoolishThings - Rolesspotbugsit.tidalwave.role.ui.impl257LOWAsDisplayableComparator.java(44,0): SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: BAD_PRACTICE: it.tidalwave.role.ui.impl.AsDisplayableComparator implements Comparator but not SerializableSE_COMPARATOR_SHOULD_BE_SERIALIZABLE0--DisplayableComparator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/DisplayableComparator.java61f04bbab317a730ab8369e0800d2a35843it.tidalwave.role.ui.impl.DisplayableComparator implements Comparator but not SerializableTheseFoolishThings - Rolesspotbugsit.tidalwave.role.ui.impl257LOWDisplayableComparator.java(43,0): SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: BAD_PRACTICE: it.tidalwave.role.ui.impl.DisplayableComparator implements Comparator but not SerializableSE_COMPARATOR_SHOULD_BE_SERIALIZABLE0--CollaborationAwareMessageBusAdapter.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Actors/src/main/java/it/tidalwave/actor/impl/CollaborationAwareMessageBusAdapter.javad2d09f575203d58ca6dc11a97fe1ab2f139139it.tidalwave.actor.impl.CollaborationAwareMessageBusAdapter.registerCollaborationListener(Method) uses the same code for two branchesTheseFoolishThings - Actorsspotbugsit.tidalwave.actor.impl247LOWCollaborationAwareMessageBusAdapter.java(139,0): DB_DUPLICATE_BRANCHES: STYLE: it.tidalwave.actor.impl.CollaborationAwareMessageBusAdapter.registerCollaborationListener(Method) uses the same code for two branchesDB_DUPLICATE_BRANCHES0--ExecutorWithPriority.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Actors/src/main/java/it/tidalwave/actor/impl/ExecutorWithPriority.java47f5fabdcbbf82f7cbc1e7f1edd289927373The class it.tidalwave.actor.impl.ExecutorWithPriority$2 could be refactored into a named _static_ inner classTheseFoolishThings - Actorsspotbugsit.tidalwave.actor.impl247LOWExecutorWithPriority.java(73,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.actor.impl.ExecutorWithPriority$2 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--ExecutorWithPriority.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Actors/src/main/java/it/tidalwave/actor/impl/ExecutorWithPriority.java37846ee1c653c72d8b3a8140d78fb389106106The class it.tidalwave.actor.impl.ExecutorWithPriority$3 could be refactored into a named _static_ inner classTheseFoolishThings - Actorsspotbugsit.tidalwave.actor.impl247LOWExecutorWithPriority.java(106,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.actor.impl.ExecutorWithPriority$3 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--RoundRobinAsyncMessageDelivery.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/RoundRobinAsyncMessageDelivery.java953ef9ecc082ff2a51996f531d2a80226147Non-null field messageBusSupport is not initialized by new it.tidalwave.messagebus.spi.RoundRobinAsyncMessageDelivery()TheseFoolishThings - MessageBusspotbugsit.tidalwave.messagebus.spi245NORMALRoundRobinAsyncMessageDelivery.java(47,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field messageBusSupport is not initialized by new it.tidalwave.messagebus.spi.RoundRobinAsyncMessageDelivery()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SimpleAsyncMessageDelivery.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/SimpleAsyncMessageDelivery.java53040b7c3286dd4fc80dba90374725714242Non-null field messageBusSupport is not initialized by new it.tidalwave.messagebus.spi.SimpleAsyncMessageDelivery()TheseFoolishThings - MessageBusspotbugsit.tidalwave.messagebus.spi245NORMALSimpleAsyncMessageDelivery.java(42,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field messageBusSupport is not initialized by new it.tidalwave.messagebus.spi.SimpleAsyncMessageDelivery()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SimpleMessageBus.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/MessageBus/src/main/java/it/tidalwave/messagebus/spi/SimpleMessageBus.javadedc8406d099b7891eac4112cb475dfa161161Adding elements of an entry set may fail due to reuse of Map.Entry object in it.tidalwave.messagebus.spi.SimpleMessageBus.dispatchMessage(Class, Object)TheseFoolishThings - MessageBusspotbugsit.tidalwave.messagebus.spi245LOWSimpleMessageBus.java(161,0): DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS: BAD_PRACTICE: Adding elements of an entry set may fail due to reuse of Map.Entry object in it.tidalwave.messagebus.spi.SimpleMessageBus.dispatchMessage(Class, Object)DMI_ENTRY_SETS_MAY_REUSE_ENTRY_OBJECTS0--FileTextReadable.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/io/spi/FileTextReadable.javad1c95eb8480a65f032bc119bf235227e6060Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextReadable.openReader(): new java.io.FileReader(File)TheseFoolishThings - Rolesspotbugsit.tidalwave.role.io.spi252LOWFileTextReadable.java(60,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextReadable.openReader(): new java.io.FileReader(File)DM_DEFAULT_ENCODING0--FileTextWritable.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/io/spi/FileTextWritable.java826714ff1b299e900223b463d50993d66060Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextWritable.openWriter(): new java.io.FileWriter(File)TheseFoolishThings - Rolesspotbugsit.tidalwave.role.io.spi252LOWFileTextWritable.java(60,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextWritable.openWriter(): new java.io.FileWriter(File)DM_DEFAULT_ENCODING0--DefaultContextManager.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/spi/DefaultContextManager.javaf35375e36ab9953bfabfabc0dc61b7375656The class it.tidalwave.role.spi.DefaultContextManager$1 could be refactored into a named _static_ inner classTheseFoolishThings - Rolesspotbugsit.tidalwave.role.spi247LOWDefaultContextManager.java(56,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spi.DefaultContextManager$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--WeakCopyFunctionSupport.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/function/WeakCopyFunctionSupport.javaa652e9a29a77fcd074d7d6d0e2f671ff5049Non-null field targetValue is not initialized by new it.tidalwave.role.ui.function.WeakCopyFunctionSupport(ChangingSource)TheseFoolishThings - Rolesspotbugsit.tidalwave.role.ui.function247NORMALWeakCopyFunctionSupport.java(49,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field targetValue is not initialized by new it.tidalwave.role.ui.function.WeakCopyFunctionSupport(ChangingSource)NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--DefaultPresentationModel.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/DefaultPresentationModel.java73879f688c67255db4df498ae18fc450106106Redundant nullcheck of role, which is known to be non-null in it.tidalwave.role.ui.impl.DefaultPresentationModel$1.run(Throwable)TheseFoolishThings - Rolesspotbugsit.tidalwave.role.ui.impl252LOWDefaultPresentationModel.java(106,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of role, which is known to be non-null in it.tidalwave.role.ui.impl.DefaultPresentationModel$1.run(Throwable)RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--MessageBusAdapterFactory.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/MessageBusAdapterFactory.java913a23124b07942dd9e763261ca3fc847474Invocation of reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block, in new it.tidalwave.messagebus.impl.spring.MessageBusAdapterFactory$MessageBusListenerAdapter(MessageBusAdapterFactory, Object, Method, Class)TheseFoolishThings - MessageBus (Spring)spotbugsit.tidalwave.messagebus.impl.spring247LOWMessageBusAdapterFactory.java(74,0): DP_DO_INSIDE_DO_PRIVILEGED: MALICIOUS_CODE: Invocation of reflect.Method.setAccessible(boolean), which should be invoked from within a doPrivileged block, in new it.tidalwave.messagebus.impl.spring.MessageBusAdapterFactory$MessageBusListenerAdapter(MessageBusAdapterFactory, Object, Method, Class)DP_DO_INSIDE_DO_PRIVILEGED0--SpringSimpleMessageSubscriberAspect.ajMALICIOUS_CODE00-it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberAspect.aj945c612de87a60bfe1c843d80952bb1000it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance isn't final but should beTheseFoolishThings - MessageBus (Spring)spotbugsit.tidalwave.messagebus.impl.spring247LOWSpringSimpleMessageSubscriberAspect.aj(0,0): MS_SHOULD_BE_FINAL: MALICIOUS_CODE: it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberAspect.ajc$perSingletonInstance isn't final but should beMS_SHOULD_BE_FINAL0--SpringSimpleMessageSubscriberSupport.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberSupport.javac0ed73ccf8503779c71bf94acc367a9a5551Non-null field beanFactory is not initialized by new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object)TheseFoolishThings - MessageBus (Spring)spotbugsit.tidalwave.messagebus.impl.spring247NORMALSpringSimpleMessageSubscriberSupport.java(51,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field beanFactory is not initialized by new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object)NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SpringSimpleMessageSubscriberSupport.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringMessageBus/src/main/java/it/tidalwave/messagebus/impl/spring/SpringSimpleMessageSubscriberSupport.java688c861135187c1691e2fbed36b21fb55151Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object)TheseFoolishThings - MessageBus (Spring)spotbugsit.tidalwave.messagebus.impl.spring247LOWSpringSimpleMessageSubscriberSupport.java(51,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.messagebus.impl.spring.SpringSimpleMessageSubscriberSupport(Object)RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--AsExtensionsBean.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/AsExtensionsBean.java85c95610871f56a489ed45cc878e46034343Non-null field roleManager is not initialized by new it.tidalwave.role.AsExtensionsBean()TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role247NORMALAsExtensionsBean.java(43,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field roleManager is not initialized by new it.tidalwave.role.AsExtensionsBean()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--AsExtensionsBean.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/AsExtensionsBean.javadef6b28b82301bd1734fbe86d9bfd7c84343Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.AsExtensionsBean()TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role247LOWAsExtensionsBean.java(43,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.AsExtensionsBean()RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--AnnotationSpringRoleManager.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/AnnotationSpringRoleManager.java5d08c3edb7d5acac184e168e21adb0ba5755Non-null field beanFactory is not initialized by new it.tidalwave.role.spring.spi.AnnotationSpringRoleManager()TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247NORMALAnnotationSpringRoleManager.java(55,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field beanFactory is not initialized by new it.tidalwave.role.spring.spi.AnnotationSpringRoleManager()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--DciContextWithAutoThreadBindingAspect.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.java8221265e527a9496b701f4e3820e17100it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance isn't final but should beTheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247LOWDciContextWithAutoThreadBindingAspect.java(0,0): MS_SHOULD_BE_FINAL: MALICIOUS_CODE: it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect.ajc$perSingletonInstance isn't final but should beMS_SHOULD_BE_FINAL0--DciContextWithAutoThreadBindingAspect.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/DciContextWithAutoThreadBindingAspect.java28d49b7dd74014600bc6b0c1c2d7abc27171The class it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect$1 could be refactored into a named _static_ inner classTheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247LOWDciContextWithAutoThreadBindingAspect.java(71,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spring.spi.DciContextWithAutoThreadBindingAspect$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--SpringAsDelegate.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/SpringAsDelegate.java3740f1e0b77f6200eb32775dff2a613b7067Non-null field roleManager is not initialized by new it.tidalwave.role.spring.spi.SpringAsDelegate()TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247NORMALSpringAsDelegate.java(67,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field roleManager is not initialized by new it.tidalwave.role.spring.spi.SpringAsDelegate()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SpringAsDelegate.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/SpringAsDelegate.java999379a6711ab178c7d6aecca2d7daa88380Non-null field roleManager is not initialized by new it.tidalwave.role.spring.spi.SpringAsDelegate(Object)TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247NORMALSpringAsDelegate.java(80,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field roleManager is not initialized by new it.tidalwave.role.spring.spi.SpringAsDelegate(Object)NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SpringAsDelegate.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/SpringAsDelegate.javaf5a8c91a215190cd69936adfe6d747776767Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.SpringAsDelegate()TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247LOWSpringAsDelegate.java(67,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.SpringAsDelegate()RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--SpringAsDelegate.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/SpringAsDelegate.java5bf9eb10bc301b988cac93b49d1bfcad8080Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.SpringAsDelegate(Object)TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247LOWSpringAsDelegate.java(80,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.SpringAsDelegate(Object)RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--SpringContextManagerProvider.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/SpringContextManagerProvider.javafae4785cd5e065d58537474965973c354343Non-null field contextManager is not initialized by new it.tidalwave.role.spring.spi.SpringContextManagerProvider()TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247NORMALSpringContextManagerProvider.java(43,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field contextManager is not initialized by new it.tidalwave.role.spring.spi.SpringContextManagerProvider()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SpringContextManagerProvider.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/SpringRoles/src/main/java/it/tidalwave/role/spring/spi/SpringContextManagerProvider.javaf9caa10f3602ce123bf38bbe83f97fa14343Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.SpringContextManagerProvider()TheseFoolishThings - Roles (Spring)spotbugsit.tidalwave.role.spring.spi247LOWSpringContextManagerProvider.java(43,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of this, which is known to be non-null in new it.tidalwave.role.spring.spi.SpringContextManagerProvider()RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--DefaultFilterSortCriterion.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/DefaultFilterSortCriterion.javab138b3ecdc3d13a03ae80abdb6a18d1e00Class it.tidalwave.util.DefaultFilterSortCriterion defines non-transient non-serializable instance field comparatorTheseFoolishThings - Utilitiesspotbugsit.tidalwave.util245LOWDefaultFilterSortCriterion.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.util.DefaultFilterSortCriterion defines non-transient non-serializable instance field comparatorSE_BAD_FIELD0--EmptyAsDelegateProvider.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/impl/EmptyAsDelegateProvider.java6fc1c213b21228d2ddd0f6e959c625834545The class it.tidalwave.util.impl.EmptyAsDelegateProvider$1 could be refactored into a named _static_ inner classTheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.impl252LOWEmptyAsDelegateProvider.java(45,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.util.impl.EmptyAsDelegateProvider$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java22a61a349131452fc20a230179a88cee483483Use of non-localized String.toUpperCase() or String.toLowerCase() in it.tidalwave.util.spi.DefaultProcessExecutor.isWindows()TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(483,0): DM_CONVERT_CASE: I18N: Use of non-localized String.toUpperCase() or String.toLowerCase() in it.tidalwave.util.spi.DefaultProcessExecutor.isWindows()DM_CONVERT_CASE0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java546fcec2f3fc51e896f3a93765e3b9a9428428Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor.start(): new java.io.PrintWriter(OutputStream, boolean)TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(428,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor.start(): new java.io.PrintWriter(OutputStream, boolean)DM_DEFAULT_ENCODING0--DefaultProcessExecutor.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javacf72bf19c353afd0d889c0f512a33b98455455Useless control flow in it.tidalwave.util.spi.DefaultProcessExecutor.waitForCompletion()TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(455,0): UCF_USELESS_CONTROL_FLOW: STYLE: Useless control flow in it.tidalwave.util.spi.DefaultProcessExecutor.waitForCompletion()UCF_USELESS_CONTROL_FLOW0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java282979a34723be2e2509ea3ef5ab71c6280280Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read(): new java.io.InputStreamReader(InputStream)TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(280,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read(): new java.io.InputStreamReader(InputStream)DM_DEFAULT_ENCODING0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaa4ff01756de9ea4b0bf187d6935c6579319319Naked notify in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(319,0): NN_NAKED_NOTIFY: MT_CORRECTNESS: Naked notify in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()NN_NAKED_NOTIFY0--DefaultProcessExecutor.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaf53c819baaf66f7ccd0135a0b88105ee158158Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(158,0): RV_RETURN_VALUE_IGNORED_BAD_PRACTICE: BAD_PRACTICE: Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()RV_RETURN_VALUE_IGNORED_BAD_PRACTICE0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java45757508fede6ce813179388b36a1e30253253Unconditional wait in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.waitFor(String)TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(253,0): UW_UNCOND_WAIT: MT_CORRECTNESS: Unconditional wait in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.waitFor(String)UW_UNCOND_WAIT0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java7dd36ac3b2d18d0f8ce1e363d50ebef1300300Increment of volatile field it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.li in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(300,0): VO_VOLATILE_INCREMENT: MT_CORRECTNESS: Increment of volatile field it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.li in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()VO_VOLATILE_INCREMENT0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java7dd36ac3b2d18d0f8ce1e363d50ebef1314314Increment of volatile field it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.li in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()TheseFoolishThings - Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(314,0): VO_VOLATILE_INCREMENT: MT_CORRECTNESS: Increment of volatile field it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.li in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()VO_VOLATILE_INCREMENT0--DisplayableExample.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciDisplayableExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/displayable/DisplayableExample.javaef9f74a40652b34ef55de3d6707545304545Non-null field contextManager is not initialized by new it.tidalwave.thesefoolishthings.examples.dci.displayable.DisplayableExample()TheseFoolishThings Examples - DCI Displayablespotbugsit.tidalwave.thesefoolishthings.examples.dci.displayable247NORMALDisplayableExample.java(45,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field contextManager is not initialized by new it.tidalwave.thesefoolishthings.examples.dci.displayable.DisplayableExample()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--DciMarshalXStreamExample.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciMarshalXStreamExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/marshal/xstream/DciMarshalXStreamExample.javab7578c7fe9b3ecd553b67dbaa05b3f765151Non-null field contextManager is not initialized by new it.tidalwave.thesefoolishthings.examples.dci.marshal.xstream.DciMarshalXStreamExample()TheseFoolishThings Examples - DCI Marshal XStreamspotbugsit.tidalwave.thesefoolishthings.examples.dci.marshal.xstream247NORMALDciMarshalXStreamExample.java(51,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field contextManager is not initialized by new it.tidalwave.thesefoolishthings.examples.dci.marshal.xstream.DciMarshalXStreamExample()NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--SwingPersonPresentation.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/swing/SwingPersonPresentation.javaf131a611fe9c5be4316ede9a29b6067f00Class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation defines non-transient non-serializable instance field bindingsTheseFoolishThings Examples - DCI Swingspotbugsit.tidalwave.thesefoolishthings.examples.dci.swing.swing247LOWSwingPersonPresentation.java(0,0): SE_BAD_FIELD: BAD_PRACTICE: Class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation defines non-transient non-serializable instance field bindingsSE_BAD_FIELD0--SwingPersonPresentation.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/swing/SwingPersonPresentation.java39a5e79a90d946719198c934fc95d720123123The class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation$1 could be refactored into a named _static_ inner classTheseFoolishThings Examples - DCI Swingspotbugsit.tidalwave.thesefoolishthings.examples.dci.swing.swing256LOWSwingPersonPresentation.java(123,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.thesefoolishthings.examples.dci.swing.swing.SwingPersonPresentation$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--DefaultContextManager.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/spi/DefaultContextManager.javaf8c0aad6fce8f899424c809655c08d7b224224The class it.tidalwave.role.spi.DefaultContextManager$2 could be refactored into a named _static_ inner classTheseFoolishThings - Rolesspotbugsit.tidalwave.role.spi247LOWDefaultContextManager.java(224,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spi.DefaultContextManager$2 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--DefaultContextManager.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/spi/DefaultContextManager.java7e5f5f12b5882452914ebfe4b0a4ed61242242The class it.tidalwave.role.spi.DefaultContextManager$3 could be refactored into a named _static_ inner classTheseFoolishThings - Rolesspotbugsit.tidalwave.role.spi247LOWDefaultContextManager.java(242,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spi.DefaultContextManager$3 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--SwingDciExample.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/examples/DciSwingExample/src/main/java/it/tidalwave/thesefoolishthings/examples/dci/swing/SwingDciExample.java542cf1dfa927099f0a406ab413cabd924646Dead store to control in it.tidalwave.thesefoolishthings.examples.dci.swing.SwingDciExample.run()TheseFoolishThings Examples - DCI Swingspotbugsit.tidalwave.thesefoolishthings.examples.dci.swing247LOWSwingDciExample.java(46,0): DLS_DEAD_LOCAL_STORE: STYLE: Dead store to control in it.tidalwave.thesefoolishthings.examples.dci.swing.SwingDciExample.run()DLS_DEAD_LOCAL_STORE4646 warnings (normal: 11, low: 35)