0--ContextManager.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ContextManager.java6c6bab60ae3e2877ed8414daf91907879898Public static it.tidalwave.role.ContextManager$Locator.find() may expose internal representation by returning ContextManager$Locator.contextManagerTheseFoolishThings :: Rolesspotbugsit.tidalwave.role481LOWContextManager.java(98,0): MS_EXPOSE_REP: MALICIOUS_CODE: Public static it.tidalwave.role.ContextManager$Locator.find() may expose internal representation by returning ContextManager$Locator.contextManagerMS_EXPOSE_REP0--FileTextReadable.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/io/spi/FileTextReadable.javad1c95eb8480a65f032bc119bf235227e6060Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextReadable.openReader(): new java.io.FileReader(File)TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.io.spi478LOWFileTextReadable.java(60,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextReadable.openReader(): new java.io.FileReader(File)DM_DEFAULT_ENCODING0--FileTextWritable.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/io/spi/FileTextWritable.java826714ff1b299e900223b463d50993d66060Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextWritable.openWriter(): new java.io.FileWriter(File)TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.io.spi478LOWFileTextWritable.java(60,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextWritable.openWriter(): new java.io.FileWriter(File)DM_DEFAULT_ENCODING0--DefaultContextManager.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/spi/DefaultContextManager.javaaaf0dcdbcd05ad37fd1f18230b678ef47979Overridable method append is called from constructor new it.tidalwave.role.spi.DefaultContextManager().TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.spi481LOWDefaultContextManager.java(79,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method append is called from constructor new it.tidalwave.role.spi.DefaultContextManager().MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--DefaultContextManager.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/spi/DefaultContextManager.javaf35375e36ab9953bfabfabc0dc61b7375555The class it.tidalwave.role.spi.DefaultContextManager$1 could be refactored into a named _static_ inner classTheseFoolishThings :: Rolesspotbugsit.tidalwave.role.spi478LOWDefaultContextManager.java(55,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spi.DefaultContextManager$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--BooleanBoundFunctionSupport.javaMALICIOUS_CODE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/function/BooleanBoundFunctionSupport.java7e2c04081b3015b1edb0c3b986f54a286767Overridable method function is called from constructor new it.tidalwave.role.ui.function.BooleanBoundFunctionSupport(ChangingSource[]).TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.function481LOWBooleanBoundFunctionSupport.java(67,0): MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR: MALICIOUS_CODE: Overridable method function is called from constructor new it.tidalwave.role.ui.function.BooleanBoundFunctionSupport(ChangingSource[]).MC_OVERRIDABLE_METHOD_CALL_IN_CONSTRUCTOR0--WeakCopyFunctionSupport.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/function/WeakCopyFunctionSupport.javaa652e9a29a77fcd074d7d6d0e2f671ff5049Non-null field targetValue is not initialized by new it.tidalwave.role.ui.function.WeakCopyFunctionSupport(ChangingSource)TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.function478NORMALWeakCopyFunctionSupport.java(49,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field targetValue is not initialized by new it.tidalwave.role.ui.function.WeakCopyFunctionSupport(ChangingSource)NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--AsDisplayableComparator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/AsDisplayableComparator.javad674a5e33451f39c0618fc9b4a1823225944it.tidalwave.role.ui.impl.AsDisplayableComparator implements Comparator but not SerializableTheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.impl478LOWAsDisplayableComparator.java(44,0): SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: BAD_PRACTICE: it.tidalwave.role.ui.impl.AsDisplayableComparator implements Comparator but not SerializableSE_COMPARATOR_SHOULD_BE_SERIALIZABLE0--DefaultPresentationModel.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/DefaultPresentationModel.java73879f688c67255db4df498ae18fc450109109Redundant nullcheck of role, which is known to be non-null in it.tidalwave.role.ui.impl.DefaultPresentationModel$1.run(Throwable)TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.impl478LOWDefaultPresentationModel.java(109,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of role, which is known to be non-null in it.tidalwave.role.ui.impl.DefaultPresentationModel$1.run(Throwable)RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--DisplayableComparator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/DisplayableComparator.java61f04bbab317a730ab8369e0800d2a35843it.tidalwave.role.ui.impl.DisplayableComparator implements Comparator but not SerializableTheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.impl478LOWDisplayableComparator.java(43,0): SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: BAD_PRACTICE: it.tidalwave.role.ui.impl.DisplayableComparator implements Comparator but not SerializableSE_COMPARATOR_SHOULD_BE_SERIALIZABLE1010 warnings (normal: 1, low: 9)