0--AsDelegateProvider.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/AsDelegateProvider.java799a0da694fd7b76d6611cda5e02b026141141The class it.tidalwave.util.spi.AsDelegateProvider$EmptyAsDelegateProvider$1 could be refactored into a named _static_ inner classTheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi263LOWAsDelegateProvider.java(141,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.util.spi.AsDelegateProvider$EmptyAsDelegateProvider$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java22a61a349131452fc20a230179a88cee485485Use of non-localized String.toUpperCase() or String.toLowerCase() in it.tidalwave.util.spi.DefaultProcessExecutor.isWindows()TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(485,0): DM_CONVERT_CASE: I18N: Use of non-localized String.toUpperCase() or String.toLowerCase() in it.tidalwave.util.spi.DefaultProcessExecutor.isWindows()DM_CONVERT_CASE0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java546fcec2f3fc51e896f3a93765e3b9a9430430Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor.start(): new java.io.PrintWriter(OutputStream, boolean)TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(430,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor.start(): new java.io.PrintWriter(OutputStream, boolean)DM_DEFAULT_ENCODING0--DefaultProcessExecutor.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javacf72bf19c353afd0d889c0f512a33b98457457Useless control flow in it.tidalwave.util.spi.DefaultProcessExecutor.waitForCompletion()TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(457,0): UCF_USELESS_CONTROL_FLOW: STYLE: Useless control flow in it.tidalwave.util.spi.DefaultProcessExecutor.waitForCompletion()UCF_USELESS_CONTROL_FLOW0--DefaultProcessExecutor.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java282979a34723be2e2509ea3ef5ab71c6282282Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read(): new java.io.InputStreamReader(InputStream)TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(282,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read(): new java.io.InputStreamReader(InputStream)DM_DEFAULT_ENCODING0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaa4ff01756de9ea4b0bf187d6935c6579321321Naked notify in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(321,0): NN_NAKED_NOTIFY: MT_CORRECTNESS: Naked notify in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()NN_NAKED_NOTIFY0--DefaultProcessExecutor.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.javaf53c819baaf66f7ccd0135a0b88105ee160160Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(160,0): RV_RETURN_VALUE_IGNORED_BAD_PRACTICE: BAD_PRACTICE: Exceptional return value of java.util.concurrent.ExecutorService.submit(Runnable) ignored in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.start()RV_RETURN_VALUE_IGNORED_BAD_PRACTICE0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java45757508fede6ce813179388b36a1e30255255Unconditional wait in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.waitFor(String)TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(255,0): UW_UNCOND_WAIT: MT_CORRECTNESS: Unconditional wait in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.waitFor(String)UW_UNCOND_WAIT0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java7dd36ac3b2d18d0f8ce1e363d50ebef1302302Increment of volatile field it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.li in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(302,0): VO_VOLATILE_INCREMENT: MT_CORRECTNESS: Increment of volatile field it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.li in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()VO_VOLATILE_INCREMENT0--DefaultProcessExecutor.javaMT_CORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Utilities/src/main/java/it/tidalwave/util/spi/DefaultProcessExecutor.java7dd36ac3b2d18d0f8ce1e363d50ebef1316316Increment of volatile field it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.li in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()TheseFoolishThings :: Utilitiesspotbugsit.tidalwave.util.spi245LOWDefaultProcessExecutor.java(316,0): VO_VOLATILE_INCREMENT: MT_CORRECTNESS: Increment of volatile field it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.li in it.tidalwave.util.spi.DefaultProcessExecutor$DefaultConsoleOutput.read()VO_VOLATILE_INCREMENT1010 warnings (low: 10)