0--FileTextReadable.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/io/spi/FileTextReadable.javad1c95eb8480a65f032bc119bf235227e6060Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextReadable.openReader(): new java.io.FileReader(File)TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.io.spi252LOWFileTextReadable.java(60,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextReadable.openReader(): new java.io.FileReader(File)DM_DEFAULT_ENCODING0--FileTextWritable.javaI18N00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/io/spi/FileTextWritable.java826714ff1b299e900223b463d50993d66060Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextWritable.openWriter(): new java.io.FileWriter(File)TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.io.spi252LOWFileTextWritable.java(60,0): DM_DEFAULT_ENCODING: I18N: Found reliance on default encoding in it.tidalwave.role.io.spi.FileTextWritable.openWriter(): new java.io.FileWriter(File)DM_DEFAULT_ENCODING0--DefaultContextManager.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/spi/DefaultContextManager.javaf35375e36ab9953bfabfabc0dc61b7375656The class it.tidalwave.role.spi.DefaultContextManager$1 could be refactored into a named _static_ inner classTheseFoolishThings :: Rolesspotbugsit.tidalwave.role.spi247LOWDefaultContextManager.java(56,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spi.DefaultContextManager$1 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--DefaultContextManager.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/spi/DefaultContextManager.javaf8c0aad6fce8f899424c809655c08d7b224224The class it.tidalwave.role.spi.DefaultContextManager$2 could be refactored into a named _static_ inner classTheseFoolishThings :: Rolesspotbugsit.tidalwave.role.spi247LOWDefaultContextManager.java(224,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spi.DefaultContextManager$2 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--DefaultContextManager.javaPERFORMANCE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/spi/DefaultContextManager.java7e5f5f12b5882452914ebfe4b0a4ed61242242The class it.tidalwave.role.spi.DefaultContextManager$3 could be refactored into a named _static_ inner classTheseFoolishThings :: Rolesspotbugsit.tidalwave.role.spi247LOWDefaultContextManager.java(242,0): SIC_INNER_SHOULD_BE_STATIC_ANON: PERFORMANCE: The class it.tidalwave.role.spi.DefaultContextManager$3 could be refactored into a named _static_ inner classSIC_INNER_SHOULD_BE_STATIC_ANON0--WeakCopyFunctionSupport.javaCORRECTNESS00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/function/WeakCopyFunctionSupport.javaa652e9a29a77fcd074d7d6d0e2f671ff5049Non-null field targetValue is not initialized by new it.tidalwave.role.ui.function.WeakCopyFunctionSupport(ChangingSource)TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.function247NORMALWeakCopyFunctionSupport.java(49,0): NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR: CORRECTNESS: Non-null field targetValue is not initialized by new it.tidalwave.role.ui.function.WeakCopyFunctionSupport(ChangingSource)NP_NONNULL_FIELD_NOT_INITIALIZED_IN_CONSTRUCTOR0--AsDisplayableComparator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/AsDisplayableComparator.javad674a5e33451f39c0618fc9b4a1823225944it.tidalwave.role.ui.impl.AsDisplayableComparator implements Comparator but not SerializableTheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.impl257LOWAsDisplayableComparator.java(44,0): SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: BAD_PRACTICE: it.tidalwave.role.ui.impl.AsDisplayableComparator implements Comparator but not SerializableSE_COMPARATOR_SHOULD_BE_SERIALIZABLE0--DefaultPresentationModel.javaSTYLE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/DefaultPresentationModel.java73879f688c67255db4df498ae18fc450109109Redundant nullcheck of role, which is known to be non-null in it.tidalwave.role.ui.impl.DefaultPresentationModel$1.run(Throwable)TheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.impl252LOWDefaultPresentationModel.java(109,0): RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE: STYLE: Redundant nullcheck of role, which is known to be non-null in it.tidalwave.role.ui.impl.DefaultPresentationModel$1.run(Throwable)RCN_REDUNDANT_NULLCHECK_OF_NONNULL_VALUE0--DisplayableComparator.javaBAD_PRACTICE00-../../TheseFoolishThings_Metrics/workspace/modules/Roles/src/main/java/it/tidalwave/role/ui/impl/DisplayableComparator.java61f04bbab317a730ab8369e0800d2a35843it.tidalwave.role.ui.impl.DisplayableComparator implements Comparator but not SerializableTheseFoolishThings :: Rolesspotbugsit.tidalwave.role.ui.impl257LOWDisplayableComparator.java(43,0): SE_COMPARATOR_SHOULD_BE_SERIALIZABLE: BAD_PRACTICE: it.tidalwave.role.ui.impl.DisplayableComparator implements Comparator but not SerializableSE_COMPARATOR_SHOULD_BE_SERIALIZABLE99 warnings (normal: 1, low: 8)